alloc: fix memory heap initialization #541
Conversation
|
Hi all, This is a patch to fix the bug of memory initialization in FW. |
|
Is there a corresponding issue number of the "bug"? @libinyang |
|
@wenqingfu This patch is made for the bug #539. However, as the memory issue should be very general, I believe this patch may fix some other potential unstable issues because of the memory allocation. This bug is the member base of memmap.runtime[] map and memmap.buffer[] map is set wrong. |
libinyang
force-pushed
the
init_heap_in_right_way
branch
from
90a1086
to
394dda2
Compare
|
Patch updated by adding more comments in the code. |
There was a problem hiding this comment.
Please describe what is broken with existing code and how your changes fix this in the commit message otherwise this cant be applied (even if it's correct). I've spent 20 minutes working out what is wrong with the current code that could have been avoided if you had explained in the commit message.
src/lib/alloc.c
Outdated
| int i; | ||
| int j; | ||
| int k; | ||
| int i, j; |
There was a problem hiding this comment.
please follow coding style of one variable per line.
There was a problem hiding this comment.
please follow coding style of one variable per line.
Thanks for point it out. I didn't realize we have such coding style in sof project.
| @@ -626,21 +624,19 @@ void init_heap(struct sof *sof) | |||
| /* initialise buffer map */ | |||
| for (i = 0; i < PLATFORM_HEAP_BUFFER; i++) { | |||
| heap = &memmap.buffer[i]; | |||
|
|
|||
| for (j = 0; j < heap->blocks; j++) { | |||
|
|
|||
| @@ -649,21 +645,19 @@ void init_heap(struct sof *sof) | |||
| /* initialise runtime map */ | |||
| for (i = 0; i < PLATFORM_HEAP_RUNTIME; i++) { | |||
| heap = &memmap.runtime[i]; | |||
|
|
|||
| for (j = 0; j < heap->blocks; j++) { | |||
|
|
|||
There was a problem hiding this comment.
OK for this and upper review comments.
This patch fixes the bug of runtime & buffer memory heap initialization, and sets the correct base address for each map. Signed-off-by: Libin Yang <libin.yang@intel.com>
libinyang
force-pushed
the
init_heap_in_right_way
branch
from
394dda2
to
159f118
Compare
|
this change makes issue thesofproject/linux#253 go away, can we please prioritize reviews and integration. |
This patch fixes the bug of runtime & buffer memory heap initialization and
sets the correct base for each map.
This is a generic fix and It was verified to fix the issues below:
thesofproject/linux#253
#539 duplicate of linux #253
Signed-off-by: Libin Yang libin.yang@intel.com